HADOOP-16644. Do a HEAD after a PUT to get the modtime.#1627
Closed
steveloughran wants to merge 1 commit intoapache:trunkfrom
Closed
HADOOP-16644. Do a HEAD after a PUT to get the modtime.#1627steveloughran wants to merge 1 commit intoapache:trunkfrom
steveloughran wants to merge 1 commit intoapache:trunkfrom
Conversation
steveloughran
added
enhancement
fs/s3
Contributor
Author
|
Update: this is the wrong approach. The PUT response does include the modtime in the metadata |
steveloughran
changed the title
WiP: no tests. What would a test look like? best to use some mock to fix the remote time to always be slightly different from the local. Or we make the clock of the S3A FS patchable, which is potentially the most flexible Change-Id: I2c99752647f522991b1f89dd9c43f3a2e9b98bf5
steveloughran
force-pushed
the
s3/HADOOP-16644-HEAD-after-PUT
branch
from
5b27b86 to
679fa3d
Compare
Contributor
Author
|
I've lifted the changes to the StatusProbes enum to #1601 ; that one is ready to go in, after which I'll have to fix this one up. Proposed
|
Contributor
Author
|
Update: put result doesn't include timestamp. unless we do a HEAD every time, this is in trouble. I'm going to close the patch as is. If we were to revisit this it would be needed for every file and I'd make an option for some special cases (Yarn job submission) where timestamp mismatch is a blocker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WiP: no tests. What would a test look like? best to use some mock
to fix the remote time to always be slightly different from the local.
Or we make the clock of the S3A FS patchable, which is potentially
the most flexible.
Its unfortunate we need to do this; inclusion of the result in the put response, or, if it
is there, extraction of it, is what would work best -especially as that would guarantee
consistent read on update, the way an unversioned HEAD does not
Change-Id: I2c99752647f522991b1f89dd9c43f3a2e9b98bf5